-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: table of content for non-components #2013
[BD-46] feat: table of content for non-components #2013
Conversation
Thanks for the pull request, @monteri! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
c29bc55
to
5d54ba0
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2013 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 236 236
Lines 4195 4195
Branches 1012 1012
=======================================
Hits 3845 3845
Misses 346 346
Partials 4 4 ☔ View full report in Codecov by Sentry. |
5d54ba0
to
d790c2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ToC and the code all look good. Just failing on a few linting errors and the erroneous creation of the www/package-lock.json
file.
example/src/MyComponent.jsx
Outdated
import { FavoriteBorder } from '@edx/paragon/icons'; // eslint-disable-line | ||
|
||
const MyComponent = () => { | ||
function MyComponent() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this PR is now failing on a lint error here.
d790c2a
to
2358b30
Compare
@monteri It looks like the container widths and positioning might have regressed in this work? Current state on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks!
@monteri 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Table of content for other than components pages. It is gathered by traversing heading elements on the page.
Deploy Preview
https://deploy-preview-2013--paragon-openedx.netlify.app/
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist