feat!: use css custom properties for primary color #1996
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will replace the primary color definition and its level for custom css properties(css variables) to allow the mfes customization on runtime.
Color will be defined is this way
How to test
document.documentElement.style.setProperty('--custom-primary-500', '#A00000')
, check the following gif.Note:
This is a breaking change, since components, from another libraries, could be using the primary color with sass functions as mix, darken, lighten, those functions are expecting a color variable and this replace the color for a css var that is not compatible, so the workaround is to use get-darken-color, get-mix-color and get-lighten-color functions defined in these changes
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist