feat(modal): use portals

render modal at top-level in dom via a portal instead of inside parent component BREAKING CHANGE: Modal now renders through a Portal, this may cause failures in tests or styling rules that expect the modal in specific places in the dom tree
openedx · Apr 27, 2018 · 645ceb4 · 645ceb4
1 parent ae9dd7e
commit 645ceb4
Show file tree

Hide file tree

Showing 6 changed files with 213 additions and 778 deletions.
diff --git a/.storybook/Storyshots.test.js b/.storybook/Storyshots.test.js
@@ -7,7 +7,10 @@ jest.mock("react-dom", () => {
     render: () => null,
     unmountComponentAtNode: () => null,
     findDOMNode: () => null,
+    createPortal: () => null,
   };
 });
 
-initStoryshots();
+initStoryshots({
+  storyKindRegex: /^((?!.*?Modal).)*$/,
+});