Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: drop python3.8 version in all CI/CD workflows and implementation #398

Merged
merged 2 commits into from
Sep 23, 2024
Merged

build: drop python3.8 version in all CI/CD workflows and implementation #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b6f46a
build: upgrade python version in all CI/CD workflows and implementation
mariajgrimaldi Sep 16, 2024
e1a77ce
Merge branch 'main' into MJG/update-readthedocs
mariajgrimaldi Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
run: tox

- name: Run coverage
if: matrix.python-version == '3.8' && matrix.toxenv == 'django42'
if: matrix.python-version == '3.11' && matrix.toxenv == 'django42'
uses: codecov/codecov-action@v4
with:
flags: unittests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pypi-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: setup python
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.11

- name: Install pip
run: pip install -r requirements/pip.txt
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ version: 2
build:
os: "ubuntu-22.04"
tools:
python: "3.8"
python: "3.11"

# Build documentation in the docs/ directory with Sphinx
sphinx:
Expand Down
2 changes: 0 additions & 2 deletions openedx_events/event_bus/tests/test_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ def test_missing_attribute(self):
)
assert loaded == {'def': 'ault'}

@pytest.mark.skipif(sys.version_info > (3, 9), reason="Python 3.8.x required") # Temporary until 3.8 is dropped
@override_settings(EB_LOAD_PATH='builtins.dict')
def test_bad_args_for_callable(self):
with assert_warnings([
Expand All @@ -99,7 +98,6 @@ def test_bad_args_for_callable(self):
)
assert loaded == {'def': 'ault'}

@pytest.mark.skipif(sys.version_info < (3, 9), reason="Python 3.11.x required") # Temporary until 3.8 is dropped
@override_settings(EB_LOAD_PATH='builtins.dict')
def test_bad_args_for_callable(self):
with assert_warnings([
Expand Down
3 changes: 0 additions & 3 deletions requirements/constraints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,3 @@
# This should be removed once the issue is fixed with a new astroid release or with a test_generate_avro_schemas.py
# module refactor.
astroid<3.0.0

# Temporary to Support the python 3.11 Upgrade
backports.zoneinfo;python_version<"3.9" # Newer versions have zoneinfo available in the standard library
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def is_requirement(line):
],
include_package_data=True,
install_requires=load_requirements('requirements/base.in'),
python_requires=">=3.8",
python_requires=">=3.11",
license="Apache 2.0",
zip_safe=False,
keywords='Python edx',
Expand Down