Skip to content

Commit

Permalink
refactor: addressing review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mariajgrimaldi committed Jul 28, 2021
1 parent 8707785 commit ed2c6c0
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions openedx_events/learning/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class UserNonPersonalData:
"""

id = attr.ib(type=int)
is_active = attr.ib(type=bool, default=True)
is_active = attr.ib(type=bool)


@attr.s(frozen=True)
Expand All @@ -41,19 +41,18 @@ class UserPersonalData:


@attr.s(frozen=True)
class UserData:
class UserData(UserNonPersonalData):
"""
Attributes defined for Open edX user object.
This class extends UserNonPersonalData to include PII data completing the
user object.
Arguments:
user_non_pii (UserNonPersonalData): user's Personal Identifiable
Information.
user_pii (UserPersonalData): user's Non Personal Identifiable
Information.
pii (UserPersonalData): user's Personal Identifiable Information.
"""

user_non_pii = attr.ib(type=UserNonPersonalData)
user_pii = attr.ib(type=UserPersonalData)
pii = attr.ib(type=UserPersonalData)


@attr.s(frozen=True)
Expand Down

0 comments on commit ed2c6c0

Please sign in to comment.