Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add link to hosted course demo #52

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

jswope00
Copy link
Contributor

Add a a link to a hosted instance of the course at https://training.openedx.org for people to try the course without having to import it

Add a a link to a hosted instance of the course at https://training.openedx.org for people to try the course without having to import it
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 29, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @jswope00! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@jswope00
Copy link
Contributor Author

@sarina can I merge my own pull requests or is protocol that someone else approves?

Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On most repos, someone reviews your changes and then lets you merge in the PR when you feel it's ready. I wouldn't say it's strictly necessary on this repo, but, it never hurts for someone else's eye to catch typos etc.

@mphilbrick211
Copy link

@sarina @jswope00 - can this be merged?

@jswope00 jswope00 merged commit 89b40c6 into master Mar 20, 2024
3 checks passed
@jswope00 jswope00 deleted the jswope00/add-hosted-course branch March 20, 2024 12:55
@openedx-webhooks
Copy link

@jswope00 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants