Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support Apple Git #54

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix: support Apple Git #54

merged 1 commit into from
Jun 5, 2024

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Jun 5, 2024

Bug fix

Ensure atlas reads git --version correctly when the output is

$ git --version  # On Mac
git version 2.39.3 (Apple Git-146)

The (Apple Git-146) is confusing Atlas version check.

Beause it was designed with more standard git output in mind:

$ git --version  # On Linux, with the GitHub CLI
git version 2.34.1
hub version 2.14.2

Related issues

Test locally

cd ~/bin/
curl -L https://github.com/Zeit-Labs/openedx-atlas/raw/apple_git/atlas -o atlas
chmod +x atlas
atlas --version

Slack thread

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 5, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Ensure atlas reads `git --version` correctly when the output is

```
git version 2.39.3 (Apple Git-146)
```
@OmarIthawi
Copy link
Member Author

OmarIthawi commented Jun 5, 2024

@shadinaif @brian-smith-tcril would you mind give this a quick review?

Volo confirmed it works. Slack 🎉 is unbeatable:

image

Copy link

@shadinaif shadinaif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, tanks you!

@OmarIthawi OmarIthawi merged commit 61071f7 into openedx:main Jun 5, 2024
9 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Copy link

github-actions bot commented Jun 5, 2024

🎉 This PR is included in version 0.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U released
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: Atlas support for Apple's default git
3 participants