Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add checks and debug for sem-release #31

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

OmarIthawi
Copy link
Member

@OmarIthawi OmarIthawi commented Aug 8, 2023

This is mostly an attempt to make the process a bit more robust:

  • add one more debug message
  • ensure the NEXT_VERSION is not empty before proceeding to release

This PR doesn't address the root cause which broke the the first release https://github.com/openedx/openedx-atlas/actions/runs/5786749334/attempts/1 with a 404 error

RequestError [HttpError]: Not Found
    at /home/runner/.npm/_npx/d32d92066bae6c10/node_modules/@octokit/request/dist-node/index.js:112:21
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async requestWithGraphqlErrorHandling (/home/runner/.npm/_npx/d32d92066bae6c10/node_modules/@octokit/plugin-retry/dist-node/index.js:71:20)
    at async Job.doExecute (/home/runner/.npm/_npx/d32d92066bae6c10/node_modules/bottleneck/light.js:405:18) {
  status: 404,
  response: {
    url: 'https://api.github.com/repos/openedx/openedx-atlas/releases',
    status: 404,

Testing


This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 8, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 8, 2023

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@OmarIthawi OmarIthawi force-pushed the ref-sem-release branch 2 times, most recently from b1e04a0 to 7ed260c Compare August 8, 2023 08:48
@OmarIthawi OmarIthawi marked this pull request as draft August 8, 2023 09:42
@OmarIthawi OmarIthawi force-pushed the ref-sem-release branch 2 times, most recently from f26219b to d51cacb Compare August 8, 2023 15:37
@OmarIthawi OmarIthawi marked this pull request as ready for review August 8, 2023 15:37
- add one more debug message
- ensure the NEXT_VERSION is not empty before proceeding to release

This contribution is part of the [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) which is sparked by the [Translation Infrastructure update OEP-58](https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html#specification).
@brian-smith-tcril brian-smith-tcril merged commit 4b8aecb into openedx:main Aug 10, 2023
8 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@github-actions
Copy link

🎉 This PR is included in version 0.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U released
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants