fix: APIs path and archive fix #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedbashir
changed the title
saeedbashir
changed the title
|
Please fix Lint Commit Message |
saeedbashir
changed the title
rnr
approved these changes
Jun 7, 2024
forgotvas
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address small issues with API paths and errors while creating archive.
Path issues:
Some API paths are starting without the
/. Ideally it should work and it works sometimes because ofappendingPathComponent. But most of the time, it fails and path becomesHostURLAPIPathinstead ofHostURL/APIPath. Added the/to the API paths where it was missing.Archive issue:
Some mock code was without the
#if DEBUGand it was throughing an error while creating an archive.Theme
Some changes to fix the edX theme. These changes will not impact the openedX theme.