fix: address feedback

openedx · Nov 4, 2024 · dd10adb · dd10adb
1 parent a0c24c8
commit dd10adb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/OpenEdX.xcodeproj/xcshareddata/xcschemes/OpenEdXStage.xcscheme b/OpenEdX.xcodeproj/xcshareddata/xcschemes/OpenEdXStage.xcscheme
@@ -129,12 +129,6 @@
             ReferencedContainer = "container:OpenEdX.xcodeproj">
          </BuildableReference>
       </BuildableProductRunnable>
-      <CommandLineArguments>
-         <CommandLineArgument
-            argument = "-FIRAnalyticsDebugEnabled"
-            isEnabled = "YES">
-         </CommandLineArgument>
-      </CommandLineArguments>
       <LocationScenarioReference
          identifier = "com.apple.dt.IDEFoundation.CurrentLocationScenarioIdentifier"
          referenceType = "1">

diff --git a/fastlane/Fastfile b/fastlane/Fastfile
@@ -39,6 +39,6 @@ lane :unit_tests do
     workspace: "OpenEdX.xcworkspace",
     device: "iPhone 16",
     scheme: "OpenEdXDev",
-    xcargs: "-skipPackagePluginValidation -skipMacroValidation"
+    xcargs: "-skipPackagePluginValidation -skipMacroValidation" # Ignore swiftLint plugin validation
   )
 end