Skip to content

Commit

Permalink
feat: changes after code review
Browse files Browse the repository at this point in the history
  • Loading branch information
@IvanStepanok
IvanStepanok committed May 7, 2024
1 parent d39c6f6 commit 3239008
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 14 deletions.
2 changes: 1 addition & 1 deletion Authorization/Authorization/Presentation/Login/SignInView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public struct SignInView: View {
HStack(alignment: .center) {
ProgressBar(size: 40, lineWidth: 8)
.padding(20)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
}.frame(maxWidth: .infinity)
} else {
StyledButton(CoreLocalization.SignIn.logInBtn) {
Expand Down
2 changes: 1 addition & 1 deletion Authorization/Authorization/Presentation/Reset Password/ResetPasswordView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public struct ResetPasswordView: View {
HStack(alignment: .center) {
ProgressBar(size: 40, lineWidth: 8)
.padding(20)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
}.frame(maxWidth: .infinity)
} else {
StyledButton(AuthLocalization.Forgot.request) {
Expand Down
4 changes: 2 additions & 2 deletions Discovery/Discovery/Presentation/NativeDiscovery/CourseDetailsView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public struct CourseDetailsView: View {
ProgressBar(size: 40, lineWidth: 8)
.padding(.top, 200)
.padding(.horizontal)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
}.frame(width: proxy.size.width)
} else {
RefreshableScrollViewCompat(action: {
Expand Down Expand Up @@ -132,7 +132,7 @@ public struct CourseDetailsView: View {
ProgressBar(size: 40, lineWidth: 8)
.padding(.top, 20)
.frame(maxWidth: .infinity)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion Discovery/Discovery/Presentation/WebDiscovery/DiscoveryWebview.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public struct DiscoveryWebview: View {
lineWidth: 8
)
.padding(.vertical, proxy.size.height / 2)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
}
.frame(width: proxy.size.width, height: proxy.size.height)
}
Expand Down
2 changes: 1 addition & 1 deletion Discovery/Discovery/Presentation/WebPrograms/ProgramWebviewView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public struct ProgramWebviewView: View {
lineWidth: 8
)
.padding(.vertical, proxy.size.height / 2)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
}
.frame(width: proxy.size.width, height: proxy.size.height)
}
Expand Down
2 changes: 1 addition & 1 deletion Profile/Profile/Presentation/DeleteAccount/DeleteAccountView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ public struct DeleteAccountView: View {
ProgressBar(size: 40, lineWidth: 8)
.padding(.top, 20)
.padding(.horizontal)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
} else {
StyledButton(
ProfileLocalization.DeleteAccount.comfirm,
Expand Down
2 changes: 1 addition & 1 deletion Profile/Profile/Presentation/EditProfile/EditProfileView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ public struct EditProfileView: View {
ProgressBar(size: 40, lineWidth: 8)
.padding(.top, 150)
.padding(.horizontal)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
}
}
.navigationBarHidden(false)
Expand Down
2 changes: 1 addition & 1 deletion Profile/Profile/Presentation/Profile/ProfileView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public struct ProfileView: View {
ProgressBar(size: 40, lineWidth: 8)
.padding(.top, 200)
.padding(.horizontal)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
} else {
HStack(alignment: .center, spacing: 12) {
UserAvatar(url: viewModel.userModel?.avatarUrl ?? "", image: $viewModel.updatedAvatar)
Expand Down
2 changes: 1 addition & 1 deletion Profile/Profile/Presentation/Settings/ManageAccountView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public struct ManageAccountView: View {
ProgressBar(size: 40, lineWidth: 8)
.padding(.top, 200)
.padding(.horizontal)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
} else {
userAvatar
editProfileButton
Expand Down
2 changes: 1 addition & 1 deletion Profile/Profile/Presentation/Settings/SettingsView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public struct SettingsView: View {
ProgressBar(size: 40, lineWidth: 8)
.padding(.top, 200)
.padding(.horizontal)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
} else {
manageAccount
settings
Expand Down
3 changes: 1 addition & 2 deletions Profile/Profile/Presentation/Settings/VideoQualityView.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,8 @@ public struct VideoQualityView: View {
ProgressBar(size: 40, lineWidth: 8)
.padding(.top, 200)
.padding(.horizontal)
.accessibilityIdentifier("progressbar")
.accessibilityIdentifier("progress_bar")
} else {

ForEach(viewModel.quality, id: \.offset) { _, quality in
Button(action: {
viewModel.coreAnalytics.videoQualityChanged(
Expand Down
1 change: 0 additions & 1 deletion Profile/ProfileTests/Presentation/Settings/SettingsViewModelTests.swift
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ final class SettingsViewModelTests: XCTestCase {
config: ConfigMock()
)


await viewModel.logOut()

Verify(router, .showStartupScreen())
Expand Down

0 comments on commit 3239008

Please sign in to comment.