Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: update dependencies to use @openedx scope #636

Merged

Conversation

brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Jan 12, 2024

Part of openedx/axim-engineering#23 (comment)

Description:

BREAKING CHANGE: consuming applications must now install paragon from the @openedx scope, paragon installed from the @edx scope will no longer satisfy the peer dependency
BREAKING CHANGE: consuming applications must now install frontend-build from the @openedx scope, frontend-build installed from the @edx scope will no longer satisfy the peer dependency

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@brian-smith-tcril brian-smith-tcril force-pushed the update-paragon-scope branch 2 times, most recently from 9d252f4 to 47dfb3e Compare January 12, 2024 19:11
@brian-smith-tcril brian-smith-tcril changed the title chore!: update paragon peer dependency to use @openedx scope @brian-smith-tcril chore!: update paragon dependencies to use @openedx scope Jan 12, 2024
@brian-smith-tcril brian-smith-tcril changed the title @brian-smith-tcril chore!: update paragon dependencies to use @openedx scope chore!: update paragon dependencies to use @openedx scope Jan 12, 2024
@brian-smith-tcril brian-smith-tcril changed the title chore!: update paragon dependencies to use @openedx scope chore!: update dependencies to use @openedx scope Jan 12, 2024
@brian-smith-tcril brian-smith-tcril changed the title chore!: update dependencies to use @openedx scope chore!: update dependencies to use @openedx scope Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a28aec) 83.50% compared to head (858ddad) 83.50%.
Report is 1 commits behind head on master.

❗ Current head 858ddad differs from pull request most recent head 199a4b5. Consider uploading reports for the commit 199a4b5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   83.50%   83.50%           
=======================================
  Files          40       40           
  Lines        1073     1073           
  Branches      197      197           
=======================================
  Hits          896      896           
  Misses        165      165           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review January 12, 2024 19:40
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, Brian.

package.json Outdated
@@ -74,8 +74,8 @@
"universal-cookie": "4.0.4"
},
"peerDependencies": {
"@edx/frontend-build": ">= 8.1.0 || ^12.9.0-alpha.1",
"@edx/paragon": ">= 10.0.0 < 22.0.0",
"@openedx/frontend-build": ">= 8.1.0 || ^12.9.0-alpha.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openedx/frontend-build doesn't have 12.9.0-alpha.7 build. It would crash for repos that use frontend-build alpha

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BREAKING CHANGE: consuming applications must now install `paragon` from the `@openedx` scope, `paragon` installed from the `@edx` scope will no longer satisfy the peer dependency
BREAKING CHANGE: consuming applications must now install `frontend-build` from the `@openedx` scope, `frontend-build` installed from the `@edx` scope will no longer satisfy the peer dependency
@brian-smith-tcril brian-smith-tcril merged commit 88fd140 into openedx:master Jan 16, 2024
5 checks passed
bra-i-am pushed a commit to eduNEXT/frontend-platform that referenced this pull request May 14, 2024
BREAKING CHANGE: consuming applications must now install `paragon` from the `@openedx` scope, `paragon` installed from the `@edx` scope will no longer satisfy the peer dependency
BREAKING CHANGE: consuming applications must now install `frontend-build` from the `@openedx` scope, `frontend-build` installed from the `@edx` scope will no longer satisfy the peer dependency
bra-i-am pushed a commit to eduNEXT/frontend-platform that referenced this pull request Aug 9, 2024
BREAKING CHANGE: consuming applications must now install `paragon` from the `@openedx` scope, `paragon` installed from the `@edx` scope will no longer satisfy the peer dependency
BREAKING CHANGE: consuming applications must now install `frontend-build` from the `@openedx` scope, `frontend-build` installed from the `@edx` scope will no longer satisfy the peer dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants