-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configureable header links #475
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @asadali145! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
6e5d666
to
74f17da
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 70.67% 67.71% -2.96%
==========================================
Files 24 24
Lines 358 350 -8
Branches 90 88 -2
==========================================
- Hits 253 237 -16
- Misses 103 111 +8
Partials 2 2 ☔ View full report in Codecov by Sentry. |
f6c001f
to
35287fc
Compare
Hi @asadali145! Would you mind resolving the branch conflicts while I look for someone to review for you? Thanks! |
* Added user full name option * nit
35287fc
to
d5227d4
Compare
@mphilbrick211 This should be good for a review now. |
@arbrandes What are your thoughts on this PR? It is similar to the footer PR openedx/frontend-component-footer#403 related to openedx/platform-roadmap#324 |
@asadali145, the latest on this is that we'll be addressing header configurability as part of the OEP-65/Module Federation work. For the most part, it will be done as proposed here: https://openedx.atlassian.net/wiki/spaces/OEPM/pages/4412243977/Proposal+Customizable+Header+for+LMS In the meantime, we're also adding PluginSlots to the header, such as this one. The slots should be ready by Sumac. |
@asadali145 should we pursue this via the header pluginslot instead of configuration settings? |
@pdpinch I don't think there is much that I can do at the moment per this comment on my footer PR |
My recommendation would be for us to add plugin slots to the header/footer to support customization use cases for now, I think @brian-smith-tcril is helping with this effort. As the comment @asadali145 linked mentions, we're working on a longer-term version of the header and footer which will support more customization through simple configuration. That's taking some time to get right, and won't be available for a while. Certainly not by Sumac, maybe by Teak. |
Issue
openedx/platform-roadmap#349
Description
Makes header links, labels, and User name display more customizable using the configurations.
Testing
SHOW_FULLNAME=true
DASHBOARD_URL=<ANY URL>
EXTERNAL_ACCOUNT_PROFILE_URL=<ANY URL>
SHOW_SETTINGS_LABEL=true
ACCOUNT_SETTINGS_URL=http://localhost:1997
Screenshots