Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrated notifications tray with backend apis #363

Merged
merged 5 commits into from
Jul 10, 2023

Conversation

ayesha-waris
Copy link
Contributor

@ayesha-waris ayesha-waris commented Jul 4, 2023

INF-922

Integrate the notifications tray implemented in INF-820 with the backend apis implemented in INF-875

@ayesha-waris ayesha-waris changed the title Ayesha/inf 922 feat: integrated notifications tray with backend apis Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.40 ⚠️

Comparison is base (ceb9c13) 79.15% compared to head (e44e18c) 78.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   79.15%   78.76%   -0.40%     
==========================================
  Files          31       31              
  Lines         595      598       +3     
  Branches      108      111       +3     
==========================================
  Hits          471      471              
- Misses        121      124       +3     
  Partials        3        3              
Impacted Files Coverage Δ
src/learning-header/AuthenticatedUserDropdown.jsx 92.30% <ø> (ø)
src/Notifications/NotificationSections.jsx 96.15% <100.00%> (-3.85%) ⬇️
src/Notifications/NotificationTabs.jsx 100.00% <100.00%> (ø)
...ations/data/__factories__/notifications.factory.js 100.00% <100.00%> (ø)
src/Notifications/data/api.js 100.00% <100.00%> (ø)
src/Notifications/data/slice.js 91.17% <100.00%> (-3.03%) ⬇️
src/Notifications/data/thunks.js 93.65% <100.00%> (+0.10%) ⬆️
src/Notifications/test-utils.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/Notifications/NotificationSections.jsx Outdated Show resolved Hide resolved
src/Notifications/data/api.test.js Outdated Show resolved Hide resolved
src/Notifications/data/slice.js Outdated Show resolved Hide resolved
src/Notifications/data/slice.js Outdated Show resolved Hide resolved
src/Notifications/data/thunks.js Outdated Show resolved Hide resolved
src/Notifications/data/api.test.js Outdated Show resolved Hide resolved
src/Notifications/data/redux.test.js Outdated Show resolved Hide resolved
src/Notifications/data/selector.test.jsx Outdated Show resolved Hide resolved
src/Notifications/data/thunks.js Outdated Show resolved Hide resolved
@ayesha-waris ayesha-waris merged commit 0ce451c into master Jul 10, 2023
3 checks passed
@ayesha-waris ayesha-waris deleted the Ayesha/INF-922 branch July 10, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants