-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: added test cases for UI components #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
===========================================
+ Coverage 62.39% 79.15% +16.76%
===========================================
Files 30 31 +1
Lines 585 595 +10
Branches 108 108
===========================================
+ Hits 365 471 +106
+ Misses 212 121 -91
+ Partials 8 3 -5
☔ View full report in Codecov by Sentry. |
sundasnoreen12
force-pushed
the
sundas/INF-917
branch
2 times, most recently
from
June 26, 2023 08:35
32406b9
to
31530d6
Compare
sundasnoreen12
requested review from
awais-ansari,
ayesha-waris and
asadazam93
and removed request for
awais-ansari
June 26, 2023 08:37
sundasnoreen12
force-pushed
the
sundas/INF-917
branch
from
June 26, 2023 08:39
31530d6
to
0e6a272
Compare
awais-ansari
requested changes
Jun 26, 2023
ayesha-waris
requested changes
Jun 27, 2023
sundasnoreen12
force-pushed
the
sundas/INF-917
branch
from
June 27, 2023 11:29
02bc343
to
de8783c
Compare
awais-ansari
requested changes
Jul 3, 2023
awais-ansari
approved these changes
Jul 3, 2023
ayesha-waris
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
INF-917
Added unit tests for following notifications tray components.
Index.jsx
a. Successfully showed bell icon and unseen count on it if unseen count is greater then 0
b. Successfully showed notification tray by clicking on the bell icon
c. Successfully hide notification tray by clicking on the bell icon
d. Successfully showed setting icon in the notification tray
NotificationTabs.jsx
NotificationSection.jsx
NotificationRowItem.jsx
created time for each of the notification in both last 24 hours and earlier section
Tested
npm run test