Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #346

Merged
merged 7 commits into from
Jul 5, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jun 8, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17, along with react-test-renderer to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated paragon to fix react-loading-skeleton issue

@BilalQamar95 BilalQamar95 self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -16.77 ⚠️

Comparison is base (ceb9c13) 79.15% compared to head (97bbae7) 62.39%.

❗ Current head 97bbae7 differs from pull request most recent head ef059ae. Consider uploading reports for the commit ef059ae to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #346       +/-   ##
===========================================
- Coverage   79.15%   62.39%   -16.77%     
===========================================
  Files          31       30        -1     
  Lines         595      585       -10     
  Branches      108      108               
===========================================
- Hits          471      365      -106     
- Misses        121      212       +91     
- Partials        3        8        +5     

see 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review July 4, 2023 13:12
@abdullahwaheed abdullahwaheed merged commit c3f0282 into master Jul 5, 2023
@abdullahwaheed abdullahwaheed deleted the bilalqamar95/react-upgrade-to-v17 branch July 5, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants