test: Remove support for Node 18 #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #472 +/- ##
=======================================
Coverage 91.22% 91.22%
=======================================
Files 5 5
Lines 57 57
Branches 19 19
=======================================
Hits 52 52
Misses 5 5 ☔ View full report in Codecov by Sentry. |
mumarkhan999
approved these changes
Sep 23, 2024
|
These changes look great! I'm going to hold off on merging this along with all other PRs dropping Node 18 until Sumac is cut as per openedx/public-engineering#280 |
brian-smith-tcril
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completed upgrade to Node 20 by removing the Node 18 CI check and using
.nvmrcfor version to use.See the tracking issue for further information.