Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to the new version of brand-openedx in the new scope. #354

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

feanil
Copy link

@feanil feanil commented Oct 19, 2023

Part of openedx/axim-engineering#23

This updates the @edx/brand alias to point to the brand-openedx package at
the openedx scope. This does not impact imports because this package is used
via an alias.

Part of openedx/axim-engineering#23

This updates the `@edx/brand` alias to point to the `brand-openedx` package at
the `openedx` scope. This does not impact imports because this package is used
via an alias.
@feanil feanil requested a review from a team October 19, 2023 20:01
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7e42fd) 89.09% compared to head (83fda04) 89.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files           6        6           
  Lines          55       55           
  Branches       18       18           
=======================================
  Hits           49       49           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril merged commit ca4b490 into master Oct 20, 2023
7 checks passed
@brian-smith-tcril brian-smith-tcril deleted the feanil/update_brand_dependency branch October 20, 2023 21:17
hinakhadim pushed a commit to edly-io/frontend-component-footer that referenced this pull request Dec 11, 2023
…penedx#354)

Part of openedx/axim-engineering#23

This updates the `@edx/brand` alias to point to the `brand-openedx` package at
the `openedx` scope. This does not impact imports because this package is used
via an alias.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants