Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove Transifex calls for OEP-58 | FC-0012 #361

Merged

Conversation

hopewise
Copy link
Contributor

No description provided.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 14, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 14, 2023

Thanks for the pull request, @hopewise! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@hopewise hopewise marked this pull request as ready for review October 14, 2023 05:35
@hopewise hopewise marked this pull request as draft October 14, 2023 05:35
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (94aeaff) to head (d88ee9a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   88.34%   88.34%           
=======================================
  Files         164      164           
  Lines        3448     3448           
  Branches      850      850           
=======================================
  Hits         3046     3046           
  Misses        398      398           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
@itsjeyd itsjeyd added the blocked by other work PR cannot be finished until other work is complete label Nov 2, 2023
@itsjeyd
Copy link

itsjeyd commented Feb 23, 2024

@hopewise @OmarIthawi Should this PR be added to openedx/wg-translations#20?

@itsjeyd itsjeyd removed the blocked by other work PR cannot be finished until other work is complete label Feb 23, 2024
@hopewise hopewise marked this pull request as ready for review March 14, 2024 07:11
@OmarIthawi OmarIthawi force-pushed the samir/frontend-app-support-tools branch from 81f7e12 to 132cfd0 Compare March 17, 2024 11:51
@OmarIthawi OmarIthawi force-pushed the samir/frontend-app-support-tools branch from 132cfd0 to d88ee9a Compare March 17, 2024 11:52
Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timmc-edx @brian-smith-tcril this pull request is ready to merge but pending approval from 2U.

cc: @itsjeyd

@brian-smith-tcril brian-smith-tcril merged commit c7b0faf into openedx:master Mar 20, 2024
7 checks passed
@openedx-webhooks
Copy link

@hopewise 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants