Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reskin of Profile MFE main page #1114

Merged
merged 12 commits into from
Nov 18, 2024
Merged

feat: reskin of Profile MFE main page #1114

merged 12 commits into from
Nov 18, 2024

Conversation

eemaanamir
Copy link

@eemaanamir eemaanamir commented Oct 24, 2024

Ticket: INF-1570

Backend PR: Link
edx-internal PR: Link

Reskinning the Profile MFE main page according to the provided Figma.

Before:

58ff4399398be30e272fca6cbd82712d

After:

localhost_1995_u_edx

@eemaanamir eemaanamir requested a review from a team as a code owner October 24, 2024 14:07
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 73.04075% with 86 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (a134083) to head (3eaa383).
Report is 22 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/profile-v2/data/services.js 11.11% 45 Missing and 3 partials ⚠️
src/profile-v2/forms/ProfileAvatar.jsx 73.52% 9 Missing ⚠️
src/profile-v2/data/sagas.js 82.22% 7 Missing and 1 partial ⚠️
src/index.jsx 0.00% 7 Missing ⚠️
src/profile-v2/ProfilePage.jsx 90.47% 4 Missing ⚠️
src/data/reducers.js 0.00% 2 Missing ⚠️
src/data/sagas.js 0.00% 2 Missing ⚠️
src/profile-v2/NotFoundPage.jsx 0.00% 2 Missing ⚠️
src/profile-v2/data/constants.js 0.00% 2 Missing ⚠️
src/profile-v2/CertificateCard.jsx 87.50% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1114      +/-   ##
===========================================
+ Coverage    67.12%   68.72%   +1.59%     
===========================================
  Files           51       71      +20     
  Lines          864     1180     +316     
  Branches       179      251      +72     
===========================================
+ Hits           580      811     +231     
- Misses         274      355      +81     
- Partials        10       14       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/data/reducers.js Outdated Show resolved Hide resolved
src/index.jsx Outdated Show resolved Hide resolved
src/data/reducers.js Outdated Show resolved Hide resolved
src/data/sagas.js Outdated Show resolved Hide resolved
src/data/sagas.js Outdated Show resolved Hide resolved
src/profile-v2/ProfilePage.jsx Outdated Show resolved Hide resolved
src/profile-v2/ProfilePage.jsx Outdated Show resolved Hide resolved
src/profile-v2/ProfilePage.jsx Outdated Show resolved Hide resolved
src/profile-v2/ProfilePage.jsx Outdated Show resolved Hide resolved
src/profile-v2/ProfilePage.jsx Outdated Show resolved Hide resolved
src/profile-v2/Certificates.jsx Outdated Show resolved Hide resolved
src/profile-v2/Certificates.messages.jsx Show resolved Hide resolved
src/profile-v2/ProfilePage.jsx Outdated Show resolved Hide resolved
src/profile-v2/ProfilePage.jsx Outdated Show resolved Hide resolved
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@eemaanamir eemaanamir merged commit c025310 into 2u-main Nov 18, 2024
8 checks passed
@eemaanamir eemaanamir deleted the INF-1570 branch November 18, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants