Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Remove support for Node 18 #1075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Aug 26, 2024

Note: As per openedx/public-engineering#280 this can merge after Sumac cut.

Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using .nvmrc for version to use.

See the tracking issue for further information.

@BilalQamar95 BilalQamar95 requested a review from a team as a code owner August 26, 2024 09:16
@BilalQamar95 BilalQamar95 self-assigned this Aug 26, 2024
@BilalQamar95 BilalQamar95 mentioned this pull request Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.78%. Comparing base (a24fea5) to head (109239f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1075   +/-   ##
=======================================
  Coverage   66.78%   66.78%           
=======================================
  Files          51       51           
  Lines         849      849           
  Branches      174      175    +1     
=======================================
  Hits          567      567           
  Misses        272      272           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deborahgu deborahgu added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 27, 2024
@deborahgu
Copy link
Member

I'm not formally blocking this because the constraint is 2U-only, but Aperture won't be progressing this until the work to enable deploying node 20 in our environment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants