Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replaced packages @edx/paragon & @edx/frontend-build to use openedx namespace #193

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Mar 26, 2024

Part of openedx/axim-engineering#23

  • Replaced packages @edx/paragon & @edx/frontend-build to use openedx namespace. Updated imports & respective packages
  • babel-plugin-react-intl to babel-plugin-formatjs migration
  • Major version upgrades, Updating frontend-build to v14 & frontend-platform to v8 along with respective edx packages
  • Downgraded testing-library/react with respective packages to version compatible with react v17
  • Minor refactors to resolve failing tests post upgrades, updated snapshots

@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/replace-edx/paragon-frontend-build branch 5 times, most recently from 06a4e01 to 869fcd4 Compare March 28, 2024 09:46
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/replace-edx/paragon-frontend-build branch from 869fcd4 to 2fe20db Compare March 28, 2024 10:11
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (4e0dc3c) to head (2fe20db).
Report is 16 commits behind head on master.

Current head 2fe20db differs from pull request most recent head a94521e

Please upload reports for the commit a94521e to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #193   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files         130      130           
  Lines        1710     1711    +1     
  Branches      374      375    +1     
=======================================
+ Hits         1563     1564    +1     
  Misses        138      138           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 self-assigned this Mar 28, 2024
@BilalQamar95 BilalQamar95 marked this pull request as ready for review March 28, 2024 10:22
@jansenk jansenk self-requested a review June 3, 2024 18:16
@BilalQamar95
Copy link
Contributor Author

@jansenk Can you please merge this as well, since I do not have the required permissions to do so

@jansenk jansenk merged commit 7f89bfd into openedx:master Jun 4, 2024
4 checks passed
@jansenk
Copy link
Contributor

jansenk commented Jun 4, 2024

Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants