Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix for the Paragon modal shadow, which prevents clicking on an elements on the grading page #357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lunyachek
Copy link

Minor issue was found on the "View all responses" modal window. This modal window is based on the Paragon Modal component, which has top and bottom shadows to indicate that there is some content at the top or bottom. These shadows are made with :before and :after pseudo-elements and should stick to the top and bottom. Example below:

2024-09-25.15.46.53.mov

But in the Grading modal window, the bottom shadow "has a life of its own" and takes various positions on the page, sometimes covering different elements depending on the scroll position or browser window size. Sometimes it's impossible to click the submit button or select a grade.

In the example below, I colored the bottom pseudo-element :after in red for clarity, to demonstrate that it’s not sticking to the bottom of the page.

2024-09-25.16.00.24.mov

To fix this bug, it is necessary to remove the height: 100% property set for .review-modal-body > div.pgn__modal-body-content. This property was added in this commit: dd880d4

After I removed height: 100%, I didn’t notice any issues with other elements on the page. Perhaps @leangseu-edx could point out if there’s something I might have missed?

2024-09-25.16.03.54.mov

@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-unmaintained. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8809f4c) to head (a0fb120).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          111       111           
  Lines         1082      1082           
  Branches       160       160           
=========================================
  Hits          1082      1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants