Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Switch to ubuntu-latest for builds #353

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Sep 9, 2024

This code does not have any dependencies that are specific to any specific
version of ubuntu. So instead of testing on a specific version and then needing
to do work to keep the versions up-to-date, we switch to the ubuntu-latest
target which should be sufficient for testing purposes.

This work is being done as a part of openedx/platform-roadmap#377

closes #345

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7003b61) to head (7482765).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          111       111           
  Lines         1082      1082           
  Branches       159       159           
=========================================
  Hits          1082      1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'm not a CC here, but will see whether my approval moves this along :)

  • I tested this green CI and npm publishing is sufficient (which we'll see when this merges)
  • I read through the code and checked for breaking changes.

@feanil feanil requested review from pomegranited and a team September 18, 2024 14:05
This code does not have any dependencies that are specific to any specific
version of ubuntu.  So instead of testing on a specific version and then needing
to do work to keep the versions up-to-date, we switch to the ubuntu-latest
target which should be sufficient for testing purposes.

This work is being done as a part of openedx/platform-roadmap#377

closes #345
@feanil feanil merged commit 8809f4c into master Sep 20, 2024
1 check passed
@feanil feanil deleted the feanil/ubuntu_upgrade branch September 20, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test frontend-app-ora-grading on Ubuntu 24.04
3 participants