test: Remove support for Node 18

[Anas12091101]

Complete the upgrade to Node 20 by removing the Node 18 CI check and going back to using .nvmrc as the source of truth for which version to use.

See the tracking issue for further information.

[openedx-webhooks]

Thanks for the pull request, @Anas12091101!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-unmaintained. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (567a020) to head (ca6fcbc).
Report is 8 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #352   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          111       111           
  Lines         1082      1082           
  Branches       159       159           
=========================================
  Hits          1082      1082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mphilbrick211]

@brian-smith-tcril - is this something you can help review?

[Anas12091101]

@brian-smith-tcril, could you please review this PR when you have a moment?

[brian-smith-tcril]

The plan is to not drop Node 18 support until after Sumac is cut. The changes in this PR look perfect but I don't want to approve the PR and have someone accidentally merge it early.

See the DEPR for more details on this plan: openedx/public-engineering#280

[Anas12091101]

Thank you for the clarification👍

[brian-smith-tcril]

@Anas12091101 the Sumac branches have been cut so we're ready to merge these! Would you mind updating this PR to resolve conflicts? Thanks for your patience and for making the PR!

[arslanashraf7]

@Anas12091101 the Sumac branches have been cut so we're ready to merge these! Would you mind updating this PR to resolve conflicts? Thanks for your patience and for making the PR!

@brian-smith-tcril, Anas is on annual vacation and he won't be back until November 17th. I can try updating this PR on his behalf if you like. Please let me know how you'd like to proceed on this.

[arslanashraf7]

@brian-smith-tcril I think I'd just go ahead and do it. I don't have permissions to Anas's fork so I'll be creating a new PR.

[arslanashraf7]

@brian-smith-tcril I've created #365 in response to my above comments. Could you please take a look?

[brian-smith-tcril]

Thank you so much for this PR. It has been merged via #365