-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: "An unexpected error occurred" for ORA response with corrupted attached file #324
base: master
Are you sure you want to change the base?
fix: "An unexpected error occurred" for ORA response with corrupted attached file #324
Conversation
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @arbrandes! Just checking in on this... |
@mphilbrick211 friendly ping |
@arbrandes - any chance you can take a look at this one? |
7cc6ea5
to
83e2257
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 111 111
Lines 1088 1089 +1
Branches 166 165 -1
=========================================
+ Hits 1088 1089 +1 ☔ View full report in Codecov by Sentry. |
83e2257
to
b1b421e
Compare
@mphilbrick211 friendly ping |
Steps to Reproduce:
Actual Result:
An unexpected error occurred. Please click the button below to refresh the page:
After my edits, it will be displayed in the preview card:
Note:
I couldn’t figure out how to change the not-very-correct error message
Unknown errors
without major modifications.Here you can select an error message.