Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable cycle dependency error for eslint #227

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

leangseu-edx
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7bb31a9) 100.00% compared to head (7fb4840) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         1079      1079           
  Branches       159       159           
=========================================
  Hits          1079      1079           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@muselesscreator muselesscreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muselesscreator muselesscreator merged commit 78ada8c into master Jul 17, 2023
@muselesscreator muselesscreator deleted the lk/disable-cycle-eslint branch July 17, 2023 15:17
dcoa pushed a commit to eduNEXT/frontend-app-ora-grading that referenced this pull request Dec 5, 2023
* chore: disable cycle dependency error for eslint

* chore: remove done from async function

* chore: downgrade @testing-library/react to 12 for react@16 support

* fix: update integration test selection and waiting

---------

Co-authored-by: Ben Warzeski <[email protected]>
dcoa added a commit to eduNEXT/frontend-app-ora-grading that referenced this pull request Dec 15, 2023
* chore: update packages to alpha compatibility

* feat: update styles according to css variables

* chore: disable cycle dependency error for eslint (openedx#227)

* chore: disable cycle dependency error for eslint

* chore: remove done from async function

* chore: downgrade @testing-library/react to 12 for react@16 support

* fix: update integration test selection and waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants