chore: update header and footer package #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #195 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 1079 1079
Branches 159 159
=========================================
Hits 1079 1079
☔ View full report in Codecov by Sentry. |
| @@ -213,7 +218,7 @@ describe('ESG app integration tests', () => { | |||
| inspector = new Inspector(el); | |||
| }); | |||
|
|
|||
| test('initialization', async (done) => { | |||
| test('initialization', async () => { | |||
There was a problem hiding this comment.
Why are these getting removed from the integration test for this change?
There was a problem hiding this comment.
I keep getting error telling me not to use async and done in the same test. It is redundant.
There was a problem hiding this comment.
I guess is new. As long as the tests are passing, I don't really mind. was intended to make the integration tests wait until the async test was actually done, which it wasn't before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light for adding renovate to the repo, I want to make sure that this doesn't block the future package update. Because header/footer have conflict peer dependency, it prevent
npm updatefrom running properlly.