Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Readme updated according OEP-55 #194

Merged
merged 11 commits into from
Sep 12, 2023

Conversation

johnvente
Copy link
Contributor

The README of the MFE's need to be updated because the frontend app template has been updated.

Issue related: openedx/wg-frontend#169

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 28, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 28, 2023

Thanks for the pull request, @johnvente! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@johnvente johnvente changed the title [DOCS]: README updated [DOCS] Readme updated according OEP-55 Jun 28, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e25a5a9) 100.00% compared to head (114e0e6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #194   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         1079      1079           
  Branches       159       159           
=========================================
  Hits          1079      1079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 5, 2023
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 5, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 7, 2023
@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Jul 10, 2023
@mphilbrick211 mphilbrick211 requested a review from a team July 11, 2023 14:15
@mphilbrick211
Copy link

Hi @openedx/content-aurora! Would someone be able to review and merge this for us? Thanks!

Copy link
Contributor

@muselesscreator muselesscreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you!

@mphilbrick211
Copy link

Hi @johnvente!! Looks like a failing test has popped up - would you mind taking a look?

@johnvente
Copy link
Contributor Author

johnvente commented Jul 17, 2023

Hi @johnvente!! Looks like a failing test has popped up - would you mind taking a look?

Hey @mattcarter @muselesscreator! do know what could it be with the pipeline? I'm just updating the readme file, it looks like an error with the linter but it is weird

@mphilbrick211
Copy link

Hi @johnvente!! Looks like a failing test has popped up - would you mind taking a look?

Hey @mattcarter @muselesscreator! do know what could it be with the pipeline? I'm just updating the readme file, it looks like an error with the linter but it is weird

Hi @mattcarter and @muselesscreator! Just flagging this for you :)

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 2, 2023
@mphilbrick211
Copy link

Hi @johnvente!! Looks like a failing test has popped up - would you mind taking a look?

Hey @mattcarter @muselesscreator! do know what could it be with the pipeline? I'm just updating the readme file, it looks like an error with the linter but it is weird

Hi @mattcarter and @muselesscreator! Just flagging this for you :)

Following up on this @mattcarter and @muselesscreator.

@mattcarter
Copy link
Contributor

Hi @johnvente!! Looks like a failing test has popped up - would you mind taking a look?

Hey @mattcarter @muselesscreator! do know what could it be with the pipeline? I'm just updating the readme file, it looks like an error with the linter but it is weird

Hi @mattcarter and @muselesscreator! Just flagging this for you :)

Following up on this @mattcarter and @muselesscreator.

That is weird! I also see the branch is out of date; I'm rebasing, a quick check to see if that clears the error.

@mattcarter
Copy link
Contributor

Hi @johnvente!! Looks like a failing test has popped up - would you mind taking a look?

Hey @mattcarter @muselesscreator! do know what could it be with the pipeline? I'm just updating the readme file, it looks like an error with the linter but it is weird

Hi @mattcarter and @muselesscreator! Just flagging this for you :)

Following up on this @mattcarter and @muselesscreator.

That is weird! I also see the branch is out of date; I'm rebasing, a quick check to see if that clears the error.

That did it. This is all approved, I'm going to merge it.

@mattcarter mattcarter merged commit 70e13ec into openedx:master Sep 12, 2023
5 checks passed
@openedx-webhooks
Copy link

@johnvente 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants