-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Readme updated according OEP-55 #194
Conversation
Thanks for the pull request, @johnvente! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #194 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 1079 1079
Branches 159 159
=========================================
Hits 1079 1079 ☔ View full report in Codecov by Sentry. |
Hi @openedx/content-aurora! Would someone be able to review and merge this for us? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Thank you!
Hi @johnvente!! Looks like a failing test has popped up - would you mind taking a look? |
Hey @mattcarter @muselesscreator! do know what could it be with the pipeline? I'm just updating the readme file, it looks like an error with the linter but it is weird |
Hi @mattcarter and @muselesscreator! Just flagging this for you :) |
Following up on this @mattcarter and @muselesscreator. |
That is weird! I also see the branch is out of date; I'm rebasing, a quick check to see if that clears the error. |
That did it. This is all approved, I'm going to merge it. |
@johnvente 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
The README of the MFE's need to be updated because the frontend app template has been updated.
Issue related: openedx/wg-frontend#169