Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace edx.org brand dependency with openedx brand (#199) #200

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

snglth
Copy link
Contributor

@snglth snglth commented Jul 12, 2023

@edx/brand-edx.org package is not open source. @edx/brand-openedx is what is used by other MFEs by default.

Similar PR in gradebook

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 12, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 12, 2023

Thanks for the pull request, @snglth! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 14, 2023
@mphilbrick211
Copy link

Hi @snglth! Thank you for this contribution! Please let me know if you have any questions about filling out the CLA. Thanks!

@snglth
Copy link
Contributor Author

snglth commented Jul 18, 2023

@mphilbrick211 CLA was signed by my employed recently

@mphilbrick211
Copy link

Thanks, @snglth! We'll get tests enabled for you.

@e0d
Copy link
Contributor

e0d commented Jul 18, 2023

@snglth Can you provide a description of the purpose of this change?

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5492520) 100.00% compared to head (7b9f122) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #200   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         1079      1079           
  Branches       159       159           
=========================================
  Hits          1079      1079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 18, 2023
@snglth
Copy link
Contributor Author

snglth commented Jul 19, 2023

@snglth Can you provide a description of the purpose of this change?

Description provided

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 24, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 28, 2023
@e0d
Copy link
Contributor

e0d commented Jul 28, 2023

@brian-smith-tcril this seems like a straight-forward and appropriate change. Could you have a look?

@mphilbrick211
Copy link

Hi @openedx/content-aurora! Would someone be able to please merge this for us? Thanks!

@mphilbrick211 mphilbrick211 requested a review from a team August 2, 2023 12:51
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 22, 2023
@mphilbrick211
Copy link

Hi @snglth! Some branch conflicts have popped up - would you mind taking a look?

@mphilbrick211 mphilbrick211 added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Oct 3, 2023
@snglth
Copy link
Contributor Author

snglth commented Oct 3, 2023

Hi @mphilbrick211. Conflicts fixed.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 3, 2023
@mphilbrick211
Copy link

Hi @openedx/content-aurora! Would someone be able to take a look at this? We had to fix branch conflicts, so would you mind enabling the tests to run again?

@leangseu-edx leangseu-edx merged commit cc11ce0 into openedx:master Oct 10, 2023
6 checks passed
@openedx-webhooks
Copy link

@snglth 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants