Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): replace edx.org brand dependency with openedx brand (#183) #184

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

snglth
Copy link
Contributor

@snglth snglth commented Aug 8, 2023

@edx/brand-edx.org package is not open source. @edx/brand-openedx is what is used by other MFEs by default.

Similar PRs:

@openedx-webhooks
Copy link

openedx-webhooks commented Aug 8, 2023

Thanks for the pull request, @snglth! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 8, 2023
@itsjeyd
Copy link

itsjeyd commented Aug 15, 2023

Hi @snglth, thank you for this contribution!

Let us know when the changes are ready for review, please.

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Aug 15, 2023
@snglth
Copy link
Contributor Author

snglth commented Aug 16, 2023

Hi @itsjeyd,

Changes are ready for the review.

@itsjeyd
Copy link

itsjeyd commented Aug 22, 2023

Sounds good @snglth, I'll line this PR up for a test run now. Once the build is green we can get the engineering review process started.

@itsjeyd itsjeyd added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3cdcc1f) 96.46% compared to head (a89c1a3) 96.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         195      195           
  Lines        1839     1839           
  Branches      322      322           
=======================================
  Hits         1774     1774           
  Misses         60       60           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Aug 23, 2023
@itsjeyd
Copy link

itsjeyd commented Sep 13, 2023

Hi @asadazam93, this is ready for engineering review by Infinity.

EDIT: I forgot that this repo is owned by Aurora. Apologies for the confusion. @mattcarter This is ready for engineering review by Aurora.

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Sep 13, 2023
@itsjeyd
Copy link

itsjeyd commented Sep 26, 2023

@mattcarter Friendly ping about getting this PR into Aurora's queue for engineering review.

CC @openedx/content-aurora

@itsjeyd itsjeyd requested a review from a team October 10, 2023 07:14
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@itsjeyd
Copy link

itsjeyd commented Oct 13, 2023

Thanks a lot @mattcarter!

@snglth Please resolve branch conflicts here, then the changes should be ready for merge.

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. open-source-contribution PR author is not from Axim or 2U and removed open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Oct 13, 2023
package.json Outdated Show resolved Hide resolved
@snglth
Copy link
Contributor Author

snglth commented Oct 23, 2023

Resolved conflicts and picked brand from openedx organization as suggested by @arbrandes

@arbrandes arbrandes merged commit fd57523 into openedx:master Oct 23, 2023
6 checks passed
@openedx-webhooks
Copy link

@snglth 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants