-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): replace edx.org brand dependency with openedx brand (#183) #184
Conversation
Thanks for the pull request, @snglth! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @snglth, thank you for this contribution! Let us know when the changes are ready for review, please. |
Hi @itsjeyd, Changes are ready for the review. |
Sounds good @snglth, I'll line this PR up for a test run now. Once the build is green we can get the engineering review process started. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 195 195
Lines 1839 1839
Branches 322 322
=======================================
Hits 1774 1774
Misses 60 60
Partials 5 5 ☔ View full report in Codecov by Sentry. |
EDIT: I forgot that this repo is owned by Aurora. Apologies for the confusion. @mattcarter This is ready for engineering review by Aurora. |
@mattcarter Friendly ping about getting this PR into Aurora's queue for engineering review. CC @openedx/content-aurora |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Thanks a lot @mattcarter! @snglth Please resolve branch conflicts here, then the changes should be ready for merge. |
Resolved conflicts and picked brand from |
@snglth 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
@edx/brand-edx.org package is not open source. @edx/brand-openedx is what is used by other MFEs by default.
Similar PRs: