-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update outline sidebar hooks for plugins #1586
base: master
Are you sure you want to change the base?
fix: update outline sidebar hooks for plugins #1586
Conversation
Thanks for the pull request, @KristinAoki! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
+ Coverage 84.60% 84.61% +0.01%
==========================================
Files 331 332 +1
Lines 5656 5661 +5
Branches 1357 1394 +37
==========================================
+ Hits 4785 4790 +5
+ Misses 854 852 -2
- Partials 17 19 +2 ☔ View full report in Codecov by Sentry. |
@openedx/committers-frontend-app-learning this PR is ready for review |
I'll try to take a look by tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I totally understand the necessity of this, but the refactor looks reasonable to me. Thanks!
children?: React.ReactNode; | ||
} | ||
|
||
const UnitLinkWrapper: React.FC<Props> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be useful to have a JSDoc string here explaining why we have this component.
This PR moves all the
useSelector
anddispatch
calls for the outline sidebar tooutline-sidebar/hooks.jsx
and movesLink
into a separate component for theSidebarUnits.jsx
. These changes are necessary to fully support plugins. When using any of those functions inside of a plugin it causes conflicts with redux and the router.