Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: added Paragon translations #1136

Conversation

PKulkoRaccoonGang
Copy link
Contributor

  • Ensure paragonMessages gets passed to the initialization so the hardcoded English strings throughout Paragon components use translations instead.

Issue: openedx/frontend-app-gradebook#340

@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@PKulkoRaccoonGang
Copy link
Contributor Author

@adamstankiewicz I added support for Paragon translations for Frontend App Learning too because I noticed that these changes are not here 😊

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (340580c) 87.25% compared to head (286e07e) 87.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
- Coverage   87.25%   87.24%   -0.01%     
==========================================
  Files         253      253              
  Lines        4400     4389      -11     
  Branches     1112     1106       -6     
==========================================
- Hits         3839     3829      -10     
+ Misses        547      546       -1     
  Partials       14       14              
Impacted Files Coverage Δ
...urseware/course/sidebar/SidebarContextProvider.jsx 91.66% <100.00%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/connect-paragon-translations branch from 7eec77d to 286e07e Compare July 6, 2023 12:24
@adamstankiewicz adamstankiewicz merged commit 5f9c441 into openedx:master Jul 10, 2023
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

bra-i-am pushed a commit to eduNEXT/frontend-app-learning that referenced this pull request Nov 9, 2023
bra-i-am pushed a commit to eduNEXT/frontend-app-learning that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants