test: Remove support for Node 18 #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
=======================================
Coverage 70.87% 70.87%
=======================================
Files 28 28
Lines 412 412
Branches 89 89
=======================================
Hits 292 292
Misses 119 119
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
I'm not formally blocking this because the constraint is 2U-only, but Aperture won't be progressing this until the work to enable deploying node 20 in our environment is complete. |
deborahgu
added
the
waiting for eng review
jsnwesson
approved these changes
Sep 6, 2024
brian-smith-tcril
added a commit
to brian-smith-tcril/frontend-app-learner-record
that referenced
this pull request
Sep 30, 2024
This reverts commit 6d70b87. Node 18 removal PRs should be merged after Sumac is cut.
Closed
justinhynes
pushed a commit
that referenced
this pull request
Oct 7, 2024
This reverts commit 6d70b87. Node 18 removal PRs should be merged after Sumac is cut.
brian-smith-tcril
added a commit
to brian-smith-tcril/frontend-app-learner-record
that referenced
this pull request
Oct 31, 2024
This reverts commit 8ee2356.
brian-smith-tcril
added a commit
to brian-smith-tcril/frontend-app-learner-record
that referenced
this pull request
Oct 31, 2024
This reverts commit 8ee2356.
brian-smith-tcril
added a commit
to brian-smith-tcril/frontend-app-learner-record
that referenced
this pull request
Oct 31, 2024
This reverts commit 8ee2356.
brian-smith-tcril
added a commit
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complete the upgrade to Node 20 by removing the Node 18 CI check and going back to using
.nvmrcas the source of truth for which version to use.See the tracking issue for futher information.