Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [FC-0006] verifiable credentials QR code modal instructions #164

Conversation

wowkalucky
Copy link
Contributor

@wowkalucky wowkalucky commented Jul 21, 2023

The PR fixes Verifiable Credentials feature bug.

There is a modal window with step-by-step instructions (see Figma design screenshot). Those steps were shuffled.

image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 21, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @wowkalucky! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (50ba819) 69.60% compared to head (472ef60) 69.60%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   69.60%   69.60%           
=======================================
  Files          27       27           
  Lines         408      408           
  Branches       90       90           
=======================================
  Hits          284      284           
  Misses        123      123           
  Partials        1        1           
Files Changed Coverage Δ
src/components/ProgramCertificateModal/messages.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlugovGrGlib GlugovGrGlib marked this pull request as ready for review July 28, 2023 12:49
@GlugovGrGlib GlugovGrGlib self-requested a review July 28, 2023 12:49
Make user instructions more clear
@GlugovGrGlib GlugovGrGlib merged commit 27cdd11 into openedx:master Aug 1, 2023
5 checks passed
@GlugovGrGlib GlugovGrGlib deleted the bergman/oex-creds-810/fix-vc-mobile-modal branch August 1, 2023 08:49
GlugovGrGlib added a commit to raccoongang/frontend-app-learner-record that referenced this pull request Aug 1, 2023
…nedx#164)

* fix: [OeX_Cred-810] verifiable credentials QR code modal instructions

* fix: [FC-0006] update user instructions

Make user instructions more clear

---------

Co-authored-by: Glib Glugovskiy <[email protected]>
GlugovGrGlib added a commit that referenced this pull request Aug 9, 2023
* fix: [OeX_Cred-810] verifiable credentials QR code modal instructions

* fix: [FC-0006] update user instructions

Make user instructions more clear

---------

Co-authored-by: Glib Glugovskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants