feat: update react & react-dom to v17 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 69.64% 68.57% -1.08%
==========================================
Files 16 16
Lines 280 280
Branches 65 65
==========================================
- Hits 195 192 -3
- Misses 85 88 +3 ☔ View full report in Codecov by Sentry. |
…record into bilalqamar95/react-upgrade-to-v17
|
Hi @BilalQamar95! I can prioritize taking a look at this PR but would you mind fixing up the conflicts? Thanks! |
…record into bilalqamar95/react-upgrade-to-v17
Hi @justinhynes, thanks for taking this up, I have resolved the conflicts PR is now ready for review. |
justinhynes
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade React JS to v17
Description
react&react-domto v17paragonto fix react-loading-skeleton issue@edx/frontend-platform, @edx/frontend-component-header, @edx/frontend-component-footer