-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: [FC-0006] ADR #3 - suggest micro-frontend recomposition #143
docs: [FC-0006] ADR #3 - suggest micro-frontend recomposition #143
Conversation
Thanks for the pull request, @wowkalucky! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
77293ca
to
0fb6a5d
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
==========================================
- Coverage 69.64% 69.60% -0.04%
==========================================
Files 16 27 +11
Lines 280 408 +128
Branches 65 90 +25
==========================================
+ Hits 195 284 +89
- Misses 85 123 +38
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. |
@hurtstotouchfire Do you have a sense of when this will be schedule? We're not blocked, but are trying to plan. |
I would really like to get one of our front end engineers to review this and he is booked pretty solid this sprint and potentially next sprint as well. I feel confident we can review it in mid-April as we're currently pushing to hit an early April deadline. Would that be problematic? The best I can offer is bringing it into our next sprint, which runs 3/27 to 4/10. |
@wowkalucky see Kelly's comment. Does that cause schedule issues on your end? |
No, currently we are adding the extra feature in the same way this MFE was initiated. But we treat these suggestions as a tech debt (we'd like to resolve). |
This will be in our next two week sprint, which starts Monday, fyi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this work. I had a few clarifying questions and one minor suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm picking up from what Max was looking at last week. Thanks for the additional explanations, this looks good to me (aside for one paragraph that might be worth revising).
.. note:: | ||
This item continues the State Management point. | ||
|
||
At this point, micro-frontend has a pretty few interactions (data fetches) with a single backend API. We use ``getAuthenticatedHttpClient`` on a low level (e.g. directly, each time configured). We than manually manage API request results (e.g. error checking, loading states, etc.). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit suggestion: At this point, the micro-frontend has a few interactions (data fetches) with a single backend API. We use getAuthenticatedHttpClient
on a low level (e.g. directly, each time it's configured), and then handle the API request results (e.g. error checking, loading states, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated ✔️
3ce0b03
to
0200590
Compare
It looks like the requested updates have been completed and the PR is approved. Are there are additional updates expected? Can this be merged? @wowkalucky @hurtstotouchfire @MaxFrank13 @jsnwesson @GlugovGrGlib |
@justinhynes nothing from my side. |
As all CR fixes were added and PR was approved, I am changing ADR status to Accepted and merging it. Therefore, the further VC work should introduce project structure changes documented in this ADR. |
@wowkalucky 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
No description provided.