Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [FC-0006] ADR #3 - suggest micro-frontend recomposition #143

Conversation

wowkalucky
Copy link
Contributor

No description provided.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 26, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Feb 26, 2023

Thanks for the pull request, @wowkalucky! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@wowkalucky wowkalucky force-pushed the bergman/oex_creds-458/learner-record-mfe-recomposition branch from 77293ca to 0fb6a5d Compare February 27, 2023 14:42
@wowkalucky wowkalucky marked this pull request as ready for review February 27, 2023 14:43
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (3ee263e) 69.64% compared to head (4de990c) 69.60%.
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
- Coverage   69.64%   69.60%   -0.04%     
==========================================
  Files          16       27      +11     
  Lines         280      408     +128     
  Branches       65       90      +25     
==========================================
+ Hits          195      284      +89     
- Misses         85      123      +38     
- Partials        0        1       +1     

see 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d
Copy link
Contributor

e0d commented Mar 13, 2023

@hurtstotouchfire Do you have a sense of when this will be schedule? We're not blocked, but are trying to plan.

@hurtstotouchfire
Copy link
Member

I would really like to get one of our front end engineers to review this and he is booked pretty solid this sprint and potentially next sprint as well. I feel confident we can review it in mid-April as we're currently pushing to hit an early April deadline. Would that be problematic? The best I can offer is bringing it into our next sprint, which runs 3/27 to 4/10.

@e0d
Copy link
Contributor

e0d commented Mar 14, 2023

@wowkalucky see Kelly's comment. Does that cause schedule issues on your end?

@wowkalucky
Copy link
Contributor Author

@wowkalucky see Kelly's comment. Does that cause schedule issues on your end?

No, currently we are adding the extra feature in the same way this MFE was initiated. But we treat these suggestions as a tech debt (we'd like to resolve).

@hurtstotouchfire
Copy link
Member

This will be in our next two week sprint, which starts Monday, fyi.

Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work. I had a few clarifying questions and one minor suggestion

Copy link
Contributor

@jsnwesson jsnwesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm picking up from what Max was looking at last week. Thanks for the additional explanations, this looks good to me (aside for one paragraph that might be worth revising).

.. note::
This item continues the State Management point.

At this point, micro-frontend has a pretty few interactions (data fetches) with a single backend API. We use ``getAuthenticatedHttpClient`` on a low level (e.g. directly, each time configured). We than manually manage API request results (e.g. error checking, loading states, etc.).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit suggestion: At this point, the micro-frontend has a few interactions (data fetches) with a single backend API. We use getAuthenticatedHttpClient on a low level (e.g. directly, each time it's configured), and then handle the API request results (e.g. error checking, loading states, etc.).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ✔️

@wowkalucky wowkalucky force-pushed the bergman/oex_creds-458/learner-record-mfe-recomposition branch from 3ce0b03 to 0200590 Compare May 8, 2023 13:02
@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels May 10, 2023
@GlugovGrGlib GlugovGrGlib changed the title chore(docs): [F-0006] ADR #3 - suggest micro-frontend recomposition chore(docs): [FC-0006] ADR #3 - suggest micro-frontend recomposition Jul 6, 2023
@GlugovGrGlib GlugovGrGlib changed the title chore(docs): [FC-0006] ADR #3 - suggest micro-frontend recomposition docs: [FC-0006] ADR #3 - suggest micro-frontend recomposition Jul 6, 2023
@justinhynes
Copy link
Contributor

It looks like the requested updates have been completed and the PR is approved. Are there are additional updates expected? Can this be merged?

@wowkalucky @hurtstotouchfire @MaxFrank13 @jsnwesson @GlugovGrGlib

@wowkalucky
Copy link
Contributor Author

@justinhynes nothing from my side.

@GlugovGrGlib
Copy link
Member

As all CR fixes were added and PR was approved, I am changing ADR status to Accepted and merging it. Therefore, the further VC work should introduce project structure changes documented in this ADR.

@GlugovGrGlib GlugovGrGlib merged commit d70dd96 into openedx:master Aug 17, 2023
4 of 5 checks passed
@openedx-webhooks
Copy link

@wowkalucky 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@GlugovGrGlib GlugovGrGlib deleted the bergman/oex_creds-458/learner-record-mfe-recomposition branch August 17, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants