Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumping versions and updating imports to openedx/paragon and openedx/frontend-build #975

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Feb 26, 2024

Bumping versions to correlate with frontend-enterprise and updating module @edx/paragon to @openedx/paragon

openedx/frontend-enterprise#376

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 changed the title chore: bump version chore: bumping versions Feb 26, 2024
@katrinan029 katrinan029 changed the title chore: bumping versions chore: bumping versions and updating imports to openedx/paragon and openedx/frontend-build Feb 26, 2024
@katrinan029 katrinan029 marked this pull request as ready for review February 26, 2024 21:45
@katrinan029 katrinan029 requested review from a team and adamstankiewicz February 26, 2024 21:46
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits and one suggested change related to the newly added ariaLabelledby prop on the SelectableBox.Set.

README.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/skills-quiz-v2/JobCardComponent.jsx Outdated Show resolved Hide resolved
src/index.scss Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.59%. Comparing base (d36b78a) to head (fa1cc06).
Report is 164 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
- Coverage   84.87%   84.59%   -0.29%     
==========================================
  Files         320      343      +23     
  Lines        6399     7463    +1064     
  Branches     1552     1832     +280     
==========================================
+ Hits         5431     6313     +882     
- Misses        941     1112     +171     
- Partials       27       38      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 merged commit da426c6 into master Feb 28, 2024
7 checks passed
@katrinan029 katrinan029 deleted the knguyen/version-bump branch February 28, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants