Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accounnt and profile urls in env files and replace legacy url #878

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mashal-m
Copy link
Contributor

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (d36b78a) 84.87% compared to head (25de34d) 84.99%.
Report is 86 commits behind head on master.

Files Patch % Lines
src/components/course/data/hooks.jsx 87.93% 7 Missing ⚠️
src/components/my-career/VisualizeCareer.jsx 74.07% 6 Missing and 1 partial ⚠️
src/components/my-career/data/service.js 56.25% 7 Missing ⚠️
src/components/course/data/utils.jsx 95.89% 6 Missing ⚠️
src/components/my-career/AddJobRole.jsx 60.00% 5 Missing and 1 partial ⚠️
src/components/my-career/data/hooks.jsx 50.00% 6 Missing ⚠️
...n-content/course-enrollments/CourseEnrollments.jsx 81.48% 5 Missing ⚠️
...components/enterprise-user-subsidy/data/service.js 0.00% 5 Missing ⚠️
src/components/my-career/SearchJobRole.jsx 91.48% 4 Missing ⚠️
...ourse-header/data/hooks/useCourseRunCardAction.jsx 50.00% 3 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
+ Coverage   84.87%   84.99%   +0.12%     
==========================================
  Files         320      327       +7     
  Lines        6399     6870     +471     
  Branches     1552     1681     +129     
==========================================
+ Hits         5431     5839     +408     
- Misses        941     1000      +59     
- Partials       27       31       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant