Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read from fixed priced usd for course sidebar #1201

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brobro10000
Copy link
Contributor

@brobro10000 brobro10000 commented Sep 26, 2024

Updates getCoursePrice to read from fixedPriceUsd if it exists.

Since the listPrice which is defined upstream of getCoursePrice is defined by the listPrice.usd value from canRedeem, no further changes are needed in the frontend to ensure that the fixed price is displayed if it exists. This is because the source of truth for price (NormalizedContentMetadataSerializer.get_content_price [source]) has been updated to read fixed_price_usd if it exist, and propogates to the listPrice.usd downstream within canRedeem once these PRs are merged.

[Bug fix]
Fixed a bug I ran into where the subscription expiration modal became a blocking modal.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.43%. Comparing base (5f5a7c5) to head (3e3c018).

Files with missing lines Patch % Lines
src/components/course/data/utils.jsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1201      +/-   ##
==========================================
- Coverage   88.44%   88.43%   -0.01%     
==========================================
  Files         398      398              
  Lines        8456     8458       +2     
  Branches     2034     2035       +1     
==========================================
+ Hits         7479     7480       +1     
- Misses        935      936       +1     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 marked this pull request as ready for review September 26, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant