feat: create a route to handle invite keys that includes the customer slug #1200
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1200 +/- ##
=======================================
Coverage 88.44% 88.45%
=======================================
Files 398 398
Lines 8456 8459 +3
Branches 2034 2073 +39
=======================================
+ Hits 7479 7482 +3
+ Misses 935 934 -1
- Partials 42 43 +1 ☔ View full report in Codecov by Sentry. |
iloveagent57
force-pushed
the
aed/invite-route-with-slug
branch
2 times, most recently
from
efd37eb
to
b29181f
Compare
… slug The existing universal link route does not contain the enterprise slug, so for unauthenticated users, the frontend has no knowledge of which customer’s branded logistration for which to redirect. This is typically relied upon based on the `:enterpriseSlug` route parameter in the URL, which is missing for the existing universal link route. This change adds a new invite key route that includes the enterprise slug (but not under the root loader). This will enable us to produce slug-aware invite URLs from the admin portal, that receiving learners can use to become linked to the enterprise via the B2B-specific auth flow (which is customer-aware). ENT-9428
iloveagent57
force-pushed
the
aed/invite-route-with-slug
branch
from
b29181f
to
6e47f2e
Compare
adamstankiewicz
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing universal link route does not contain the enterprise slug, so for unauthenticated users, the frontend has no knowledge of which customer’s branded logistration for which to redirect. This is typically relied upon based on the
:enterpriseSlugroute parameter in the URL, which is missing for the existing universal link route. This change adds a new invite key route that includes the enterprise slug. This will enable us to produce slug-aware invite URLs from the admin portal, that receiving learners can use to become linked to the enterprise via the B2B-specific auth flow (which is customer-aware).ENT-9428
For all changes
Only if submitting a visual change