Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error in the Courses link Issue 415 #446

Closed
wants to merge 59 commits into from

Conversation

jciasenza
Copy link
Contributor

Fixes #415

What changed?
frontend-app-learner-dashboard/src/containers/LearnerDashboardHeader/LearnerDashboardMenu.jsx

in line 16
remplace
href ='/'
by
href =''

image

If something needs to be modified, let me know, thank you!!!
Atte
Juan Carlos (Aulasneo)

Developer Checklist

Test suites passing
Documentation and test plan updated, if applicable
Received code-owner approving review

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

I've done a visual code review

I've tested the new functionality

FYI: @openedx/content-aurora

@jciasenza jciasenza requested a review from a team as a code owner September 3, 2024 18:33
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 3, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @jciasenza!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @2U-aperture. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@itsjeyd itsjeyd added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 7, 2024
@MaxFrank13
Copy link
Member

Hey @jciasenza it looks like this is no longer passing CI and needs to be updated with the latest from the master branch

@MaxFrank13 MaxFrank13 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Sep 16, 2024
@e0d
Copy link

e0d commented Sep 24, 2024

@jciasenza looks like there are some failing checks, can you have a look?

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 24, 2024
@jciasenza
Copy link
Contributor Author

I review it

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (bf2bc40) to head (58038cd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #446   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         157      157           
  Lines        1387     1387           
  Branches      230      229    -1     
=======================================
  Hits         1351     1351           
  Misses         34       34           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jciasenza
Copy link
Contributor Author

I made a new push with some test changes, because in production it seems that the Courses link works well, that is to say that I made that change back

@itsjeyd
Copy link

itsjeyd commented Oct 11, 2024

Hey @jciasenza, it looks like there are some commitlint failures left to fix. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@itsjeyd itsjeyd added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Oct 24, 2024
@itsjeyd
Copy link

itsjeyd commented Oct 31, 2024

@jciasenza While this is waiting for another test run, maybe you could bring your changes up-to-date with the master branch?

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 31, 2024
renovate bot and others added 26 commits November 14, 2024 11:07
…penedx#491)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jciasenza
Copy link
Contributor Author

I'm going to close this PR since I realized that it is something that happens only in dev.

@jciasenza jciasenza closed this Nov 14, 2024
@jciasenza jciasenza deleted the jci/issue-415 branch November 14, 2024 15:01
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Error in the Courses link and in the Discover link