feat!: Remove RecommendationsPanel #437
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 95.73% 97.24% +1.51%
==========================================
Files 163 154 -9
Lines 1452 1378 -74
Branches 244 228 -16
==========================================
- Hits 1390 1340 -50
+ Misses 58 36 -22
+ Partials 4 2 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Question, and maybe not a fair question.
What is different about this track.js call for it to be separate from all the other trackers in src/tracking/trackers/?
There was a problem hiding this comment.
This brings up a good point actually.
I believe the reason why this track.js file existed was because all of the components in the /widgets directory were business code, and so as an attempt to "separate" any business logic from core logic, that included separating the trackers as well.
After this PR is merged, there will be a /widgets directory that is made up of an AppWrapper that doesn't do anything (it used to hold the Painted Door Experiment logic) and a basic LookingForAChallenge component that will no longer be a child of the RecommendationsPanel.
I don't think it needs to be a part of this PR, but I do think there's a cleanup opportunity to remove the /widgets directory and move LookingForAChallenge to live inside /src/containers/WidgetSidebar.
There was a problem hiding this comment.
Actually, I think it'd fit in the best while resolving this issue: #336
There was a problem hiding this comment.
OK, I won't be a blocker on this then. Thanks for the insight, Jason!
There was a problem hiding this comment.
This track.js file is actually new as the LookingForChallengeWidget was using an event from within the RecommendationsPanel which seemed like a not-so-great pattern. So I just made this to be a track file specific to LookingForChallengeWidget and figured we could leave the rest up to #336 if there was more cleanup to be done w.r.t. event code.
I don't think it needs to be a part of this PR, but I do think there's a cleanup opportunity to remove the /widgets directory and move LookingForAChallenge to live inside /src/containers/WidgetSidebar.
Agreed 1000%.
I'll also add that there is this issue #385 that proposes potentially removing the widgets pattern in favor of using FPF for business specific code.
There was a problem hiding this comment.
Ah, I think this further drives the point that the widgets pattern can be switched out for the PluginSlots pattern anyways. Neat!
Removes the RecommendationsPanel widget. See the below links for more information
Discourse thread
DEPR ticket #410