Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file input handler #371

Conversation

DmytroAlipov
Copy link

This is a backport from the master branch.

hasFile run only once, it will always be null

Знімок екрана 2023-10-27 о 17 33 46

hasFile run only once, it will always be null
@DmytroAlipov DmytroAlipov requested a review from a team as a code owner October 27, 2023 15:22
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 27, 2023

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/palm.master@3644172). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             open-release/palm.master      #371   +/-   ##
============================================================
  Coverage                            ?   100.00%           
============================================================
  Files                               ?       122           
  Lines                               ?      1268           
  Branches                            ?       249           
============================================================
  Hits                                ?      1268           
  Misses                              ?         0           
  Partials                            ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 27, 2023
@mphilbrick211
Copy link

mphilbrick211 commented Oct 27, 2023

Hi @openedx/content-aurora! I think this is ready for merge, the master has already been merged.

@cmltaWt0
Copy link

Looked through the diff - looks exactly the same as for master.
Seems safe to merge.
Merging.

@cmltaWt0 cmltaWt0 merged commit 66bae17 into openedx:open-release/palm.master Nov 16, 2023
6 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-import-grades-button-palm branch November 16, 2023 10:01
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants