-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix sidebar scrolling and adaptation for mobile #362
fix: fix sidebar scrolling and adaptation for mobile #362
Conversation
- fix text overload in heading - fix appearance for sidebar with a short main content - fix transformation of search and filter button on mobile - fix extra empty space below main content table - fix adaptation modal content to mobile view
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #362 +/- ##
============================================================
Coverage ? 100.00%
============================================================
Files ? 122
Lines ? 1269
Branches ? 251
============================================================
Hits ? 1269
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Apologies for the ping @arbrandes , it looks like this needs product review. |
These fixes look great, thanks for contributing! This has product review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Master is approved, so is this.
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
TL;DR -
This pull request contains minor fixes related to the responsiveness of the blocks for mobile phones. All the before and after screenshots are below.
Related Pull Requests
PR to the master branch: #363
PR to the open-release/quince.master branch: #370
What changed?
Developer Checklist
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora