feat!: remove Transifex calls for OEP-58 #353
Conversation
|
Thanks for the pull request, @hopewise! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
hopewise
force-pushed
the
samir/deprecate-transifex
branch
3 times, most recently
from
33a851a
to
37b0b23
Compare
There was a problem hiding this comment.
Thanks @hopewise! Please add back the three lines I've pointed out and this pull request should be ready to go.
This PR makes a great first contribution.
hopewise
force-pushed
the
samir/deprecate-transifex
branch
2 times, most recently
from
523522e
to
efe2c9b
Compare
|
|
||
| intl_imports = ./node_modules/.bin/intl-imports.js | ||
| transifex_utils = ./node_modules/.bin/transifex-utils.js | ||
| i18n = ./src/i18n | ||
| transifex_input = $(i18n)/transifex_input.json |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Makefile
Outdated
| rm -rf $(transifex_temp) | ||
| npm run-script i18n_extract | ||
|
|
||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
hopewise
force-pushed
the
samir/deprecate-transifex
branch
from
efe2c9b
to
0862f84
Compare
|
Thanks @hopewise! Confirming that this PR is ready to be merged as soon as openedx/wg-translations#20 is given green light. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
==========================================
- Coverage 94.98% 94.98% -0.01%
==========================================
Files 140 139 -1
Lines 1356 1355 -1
Branches 264 264
==========================================
- Hits 1288 1287 -1
Misses 60 60
Partials 8 8 ☔ View full report in Codecov by Sentry. |
itsjeyd
added
waiting on author
itsjeyd
removed
the
blocked by other work
OmarIthawi
force-pushed
the
samir/deprecate-transifex
branch
from
0862f84
to
f8f90f8
Compare
|
@itsjeyd @timmc-edx @brian-smith-tcril this one is ready for merge |
|
@hopewise 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Breaking change!
This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.
Changes
tx pullandtx pushcommands from the micro-frontend in favorof the
atlas pullcommand..jsonfiles will be committed into the repos.src/i18n/index.jsshould export and empty array so themake pull_translationsoverride it with the dynamic list of languages.OPENEDX_ATLAS_PULLflag to makeatlas pullthe default.Makefiletargets and other files.Merge timeline
This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.
The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.
Keep this pull request as a draft to prevent accidental merge.
Pre-merge checklist
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.