-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add limited_staff to allowedRoles [BB-7834] #352
fix: add limited_staff to allowedRoles [BB-7834] #352
Conversation
Thanks for the pull request, @0x29a! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Backported from [here](openedx#352).
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #352 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 139 139
Lines 1343 1343
Branches 264 264
=======================================
Hits 1275 1275
Misses 60 60
Partials 8 8
☔ View full report in Codecov by Sentry. |
@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Backported from [here](openedx#352).
Backported from [here](openedx#352).
Backported from [here](openedx#352). (cherry picked from commit cbb32d1)
Description
Users with the Course Limited Staff role, that has been added here, don't have access to the gradebook. In this PR we add this role's slug to
allowedRoles
.Testing instructions
The fix is pretty trivial, so just make sure that the slug in
allowedRoles
is equal toCourseLimitedStaffRole.ROLE
value.