Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: added Paragon translations and LANGUAGE_PREFERENCE_COOKIE_NAME #341

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Jul 6, 2023

Issue: #340

What changed?

  • Ensure paragonMessages gets passed to the initialization so the hardcoded English strings throughout Paragon components use translations instead.

Developer Checklist

  • Test suites passing
  • Documentation and test plan updated, if applicable
  • Received code-owner approving review
  • Bumped version number package.json

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@PKulkoRaccoonGang PKulkoRaccoonGang requested a review from a team as a code owner July 6, 2023 11:14
@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Jul 6, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (10cac37) 94.93% compared to head (d588ac5) 94.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #341   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         139      139           
  Lines        1343     1343           
  Branches      264      264           
=======================================
  Hits         1275     1275           
  Misses         60       60           
  Partials        8        8           
Impacted Files Coverage Δ
src/i18n/index.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PKulkoRaccoonGang
Copy link
Contributor Author

@adamstankiewicz looks like Frontend App Gradbook didn't have the required variable in LANGUAGE_PREFERENCE_COOKIE_NAME='openedx-language-preference' and the translations didn't work.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/connect-paragon-translations branch from be10773 to 085b1b7 Compare July 6, 2023 12:22
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/connect-paragon-translations branch from 085b1b7 to d588ac5 Compare July 12, 2023 07:56
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch on the LANGUAGE_PREFERENCE_COOKIE_NAME. FWIW (as a sanity check), for 2U/edX deployments of this MFE, the missing LANGUAGE_PREFERENCE_COOKIE_NAME was a non-issue in stage/production as our internal configuration sets this setting as a common environment variable applicable to all MFEs.

Definitely should be there for local dev though!

@adamstankiewicz adamstankiewicz merged commit 78d521c into openedx:master Jul 15, 2023
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

OmarIthawi added a commit to Zeit-Labs/frontend-app-gradebook that referenced this pull request Jul 22, 2023
This is a follow up to openedx#341

This pull request is part of the [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) which is sparked by the [Translation Infrastructure update OEP-58](https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html#specification).
adamstankiewicz pushed a commit that referenced this pull request Jul 22, 2023
This is a follow up to #341

This pull request is part of the [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) which is sparked by the [Translation Infrastructure update OEP-58](https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html#specification).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants