-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] feat: added Paragon translations and LANGUAGE_PREFERENCE_COOKIE_NAME #341
[BD-46] feat: added Paragon translations and LANGUAGE_PREFERENCE_COOKIE_NAME #341
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 139 139
Lines 1343 1343
Branches 264 264
=======================================
Hits 1275 1275
Misses 60 60
Partials 8 8
☔ View full report in Codecov by Sentry. |
@adamstankiewicz looks like Frontend App Gradbook didn't have the required variable in |
be10773
to
085b1b7
Compare
085b1b7
to
d588ac5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good catch on the LANGUAGE_PREFERENCE_COOKIE_NAME
. FWIW (as a sanity check), for 2U/edX deployments of this MFE, the missing LANGUAGE_PREFERENCE_COOKIE_NAME
was a non-issue in stage/production as our internal configuration sets this setting as a common environment variable applicable to all MFEs.
Definitely should be there for local dev though!
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This is a follow up to openedx#341 This pull request is part of the [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) which is sparked by the [Translation Infrastructure update OEP-58](https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html#specification).
This is a follow up to #341 This pull request is part of the [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) which is sparked by the [Translation Infrastructure update OEP-58](https://open-edx-proposals.readthedocs.io/en/latest/architectural-decisions/oep-0058-arch-translations-management.html#specification).
Issue: #340
What changed?
Developer Checklist
Testing Instructions
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora