chore: test build and platform updates #731
Draft
+103
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR to get a sandbox that tests using design tokens versions of frontend-build and frontend-platform without changing this MFE to use design tokens this is to verify that it is safe to merge the design tokens support PRs to frontend-build and frontend-platform and that they do not contain any breaking changes
brian-smith-tcril
added
the
create-sandbox
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
=======================================
Coverage 93.16% 93.16%
=======================================
Files 160 160
Lines 3396 3396
Branches 917 912 -5
=======================================
Hits 3164 3164
Misses 215 215
Partials 17 17 ☔ View full report in Codecov by Sentry. |
|
Sandbox deployment successful 🚀 |
|
This seems to be working as expected https://app.pr-731-2977b1.sandboxes.opencraft.hosting/discussions/course-v1:demo+Course+1/my-posts/66a81a7476ab1f0037f96c55 |
PKulkoRaccoonGang
approved these changes
Jul 30, 2024
|
Sandbox deployment successful 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to get a sandbox that tests using design tokens versions of frontend-build and frontend-platform without changing this MFE to use design tokens
ParagonWebpackPluginto support design tokens frontend-build#546this is to verify that it is safe to merge the design tokens support PRs to frontend-build and frontend-platform and that they do not contain any breaking changes
How Has This Been Tested?
Please describe in detail how you tested your changes.
Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.
Merge Checklist
Post-merge Checklist