Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated README file to reflect template changes #592

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

Mashal-m
Copy link
Contributor

Description

The README of the MFEs needs to be updated because the frontend app template has been updated.

Issue related: openedx/wg-frontend#169

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1cb8ad3) 92.32% compared to head (95d5cf0) 92.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         169      169           
  Lines        3451     3451           
  Branches      899      899           
=======================================
  Hits         3186     3186           
  Misses        244      244           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m marked this pull request as ready for review October 31, 2023 08:19
@sundasnoreen12
Copy link
Contributor

@Mashal-m Please resolve the conflict in the README.rst file. Once this is done, I will perform a final review.

@Mashal-m
Copy link
Contributor Author

@Mashal-m Please resolve the conflict in the README.rst file. Once this is done, I will perform a final review.

conflicts resolved!

@Mashal-m Mashal-m merged commit 67700e8 into master Oct 31, 2023
6 checks passed
@Mashal-m Mashal-m deleted the mashal-m/update-README branch October 31, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants